Code review comment for lp:~zsombi/ubuntu-ui-toolkit/contextual_actions

Revision history for this message
Zsombor Egri (zsombi) wrote :

> By registered I meant "will invoke its action when pressed".
>
> How about:
>
> ActionContext drives the state of its \l actions. Shortcuts and mnemonics are
> only registered if the context is active or if the action is assigned to an \l
> ActionItem all of whose parent contexts are active.
>

Much better :)

> So you are disagreeing with the explanation given in the example? Which says
> "rootContext will never be triggered through the \c {Ctrl+A} shortcut". But
> you are saying the rootContext can be used because the action is declared as a
> child. Which logically has to mean that its shortcut can work as well - the
> shortcut should be active whenever its Action is effectively active.

Ou, hell, right! So I have to fix the sample and put an Action which is neither in an ActionContext nor assigned to an ActionItem!!!

« Back to merge proposal