Code review comment for lp:~zsombi/ubuntu-ui-toolkit/combobutton

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 364 + /* ----------------- Color and font configurations -----------------
> */
> 365 + /*!
> 366 + The property specifies the color of the dropdown button when
> expanded.
> 367 + */
> 368 + property color dropdownColorPressed: __styleInstance ?
> __styleInstance.defaultDropdownColorPressed : color
> 369 +
> 370 + /*!
> 371 + The property specifies the color of the dropdown button when
> collapsed.
> 372 + */
> 373 + property color dropdownColorReleased: __styleInstance ?
> __styleInstance.defaultDropdownColorReleased : color
>
>
> 1 - check for hasOwnProperty(defaultDropdownColorPressed /
> defaultDropdownColorReleased).

Nope. As said, style API will need to match in order to have the component working properly.

> 2 - In this case expanded and collapsed is better than pressed/released, since
> you don't have to keep pressing to keep the item expanded.
> 3 - in the documentation, say the BACKGROUND color of the dropdown button AND
> THE COMBO LIST.

Agree. Will fix that.

« Back to merge proposal