Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/combobutton

  1. combobutton
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> 348 + readonly property real comboListHeight: (expandedHeight < 0) ?
> 349 + comboListHolder.height :
> 350 + (expandedHeight - collapsedHeight -
> 351 + (combo.__styleInstance ? combo.__styleInstance.comboListMargin : 0))
> 352 +
>
> Just to be safe with custom styles, check for
> combo.__styleInstance.hasOwnProperty(comboListMargin)

Actually we should not do that anymore. This is the first component that has the style API fixed, so we should no longer check for the existence of the properties.

« Back to merge proposal