Code review comment for lp:~zsombi/ubuntu-ui-toolkit/combobutton
Revision history for this message
| Zsombor Egri (zsombi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> 362 + default property alias comboList: comboListHolder
>
> Is it needed to make this the default property? Does it make the code more
> clear to have the elements in the comboList as children of the ComboButton
> instead of giving this property?
And what would you do with the children components added to it eventually? Where would you put those? At least in this way you are sure that it lands in the combo list...
>
> If we keep the 'default' here, add a remark in the documentation that the
> children of the ComboButton are what will appear in the "panel" when expanded.
It's there :)