Code review comment for lp:~zsombi/ubuntu-ui-toolkit/combobutton

Revision history for this message
Tim Peeters (tpeeters) wrote :

473 + // drive the expansion height of the combo list holder
474 + Binding {
475 + target: combo.__styleInstance.comboListPanel
476 + property: "height"
477 + value: {
478 + if (!expanded) {
479 + return 0;
480 + }
481 + if (comboListHolder.anchorFill) {
482 + return combo.comboListHeight + combo.__styleInstance.comboListMargin;
483 + }
484 +
485 + var h = comboListHolder.height;
486 + var max = combo.comboListHeight + combo.__styleInstance.comboListMargin;
487 + if (combo.expandedHeight < 0) {
488 + return max;
489 + }
490 +
491 + return MathUtils.clamp(h, 0, max);
492 + }
493 + }

This belongs in the style.

review: Needs Fixing

« Back to merge proposal