Code review comment for lp:~zsombi/ubuntu-ui-toolkit/combobutton

Revision history for this message
Tim Peeters (tpeeters) wrote :

in onCompleted:

398 + // bind a height calculation to avoid unwanted change
399 + combo.height = Qt.binding(function() {return collapsedHeight + __styleInstance.comboListPanel.height});

hmm.. so if the developers set combo.height, it will be overridden in onCompleted? That will cause confusion. At least mention it in the docs, or preferably find another way to do this.

« Back to merge proposal