Code review comment for lp:~zsombi/ubuntu-ui-toolkit/78-action-property

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 169 + * \note Handling pressAndHold will suppress the action triggering as
> the clicked
> 170 + * signal is also suppressed. If the action triggering is still
> needed, it must be
> 171 + * triggered manually on \l highlighted changed.
>
> this is odd. We had something similar in a previous MR.
>
> But it is possible to support both clicked and longpress. From the text it
> appears as if defining onPressAndHold:..., action handling will be disabled.
> But I think what it means is that if pressAndHold happens, no clicked event
> will follow. I think it is already clear that there will be no clicked() event
> after pressAndHold.

I think what we did we simply removed from the #77 MR, as this cannot really be formulated to be understandable enough. Let's do the same here.

« Back to merge proposal