Code review comment for lp:~zsombi/ubuntu-ui-toolkit/76-refactoring

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 1193 + Q_PROPERTY(UCListItemActions *actions READ actions NOTIFY
> actionsChanged)
> 1194 + Q_PROPERTY(QQmlListProperty<UCAction> visibleActions READ
> visibleActions NOTIFY visibleActionsChanged)
> 1195 + Q_PROPERTY(UCListItem *item READ item NOTIFY itemChanged)
> 1196 + Q_PROPERTY(int index READ index NOTIFY indexChanged)
> 1197 + Q_PROPERTY(UCListItem::PanelStatus panelStatus READ panelStatus
> NOTIFY panelStatusChanged)
>
> why do we need to expose all of these publicly?

How would you implement a panel without them?
- actions contains the ListItemActions the panell is about to visualize
- visibleActions is a helper property, which is updated automatically whenever an action.visible is changed, without this the QML code would be a bit painful
- index provides info about the ListItem index, however that can be accessed as well as context property, perhaps we can remove it
- the panelStatus is needed in order to know which panel is the instance

So apart from 'index' I don't know what to remove.

« Back to merge proposal