Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/76-refactoring

  1. 76-refactoring
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> 423 +void UCListItemSnapAnimator::stop()
> 424 +{
> 425 + QQuickPropertyAnimation *snap = getDefaultAnimation();
> 426 + if (snap && snap->isRunning()) {
> 427 + snap->stop();
> 428 + }
> 429 +}
>
> where do you use this?
> perhaps you should be calling this function in snap() instead of calling
> snap->stop() there.

Check the code :) It is used when mousePressed() is called, so if there is an animation, it will stop it => no binding loop on swiped property

« Back to merge proposal