Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/76-refactoring

  1. 76-refactoring
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> 62 - ListItemActions.visibleActions.length *
> MathUtils.clamp(visualizedActionWidth, height, actionsRow.maxItemWidth))
> 63 + ListItem.visibleActions.length *
> MathUtils.clamp(visualizedActionWidth, height, actionsRow.maxItemWidth))
>
> visualizedActionWidth was there before, but I noticed this only now:
> would it be more consistent with other QML classes if we named this
> paintedActionWidth? For example, Image has a paintedWidth.
>
> Text had paintedWidth also.. but it seems to be removed in QtQuick 2.4? I
> don't see it here any more http://doc.qt.io/qt-5/qml-qtquick-text.html

Ack, revno 1397.

« Back to merge proposal