Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/76-refactoring

  1. 76-refactoring
  2. Merge into staging
Revision history for this message
Tim Peeters (tpeeters) wrote :

143 - var snapPos = (ListItemActions.offset > ListItemActions.listItem.swipeOvershoot && snapIn) ? panel.width : 0.0;
144 - ListItemActions.snapToPosition(snapPos);
145 + var snapPos = (swipedOffset > units.gu(2) && snapIn) ? panel.width : 0.0;
146 + ListItem.snapToPosition(snapPos);
147 }

You replaced swipeOvershoot by a hard-coded value here. Is that an improvement? It is better to have a constant defined.

« Back to merge proposal