Ubuntu UI Toolkit

Code review comment for lp:~zsombi/ubuntu-ui-toolkit/35-options-panel-swipe

  1. 35-options-panel-swipe
  2. Merge into listitem-master
Revision history for this message
Zsombor Egri (zsombi) wrote :

> 321 + , xAxisMoveThresholdGU(1.5)
> 322 , overshoot(UCUnits::instance().gu(2))
>
> let's do the x-axis threshold like the overshoot, so:
> xAxisMoveThreshold(UCUnits::instance().gu(1.5))

No, I would not. Especially that this is not configurable. If we decide to make it configurable, we can do it later. Yet, there's no reason to watch the units change to update this property, as we need the threshold only when swiping. And if we don't configure it, we can always get the proper pixel amount by converting in place.

« Back to merge proposal