Code review comment for lp:~zsombi/ubuntu-ui-toolkit/32-listitemactions-attached

Revision history for this message
Zsombor Egri (zsombi) wrote :

> > The component provides two color properties which configures the item's
> background
> > when normal or pressed.
>
> > This can be configures through color and highlightColor properties.
>
> configureD

ehh...

>
>
> highlightColor only applies when pressed? With previous list items that color
> was used when pressed || selected.

Will be applied also when selected, just did not wanted to add it here yet, will come when the selection mode will be implemented, in MR #80

>
>
>
> > void UCListItemPrivate::_q_updateColors()
> > {
> > Q_Q(UCListItem);
> > highlightColor = getPaletteColor("selected", "background");
> > q->update();
> > }
>
> should this also update color?
Not yet, as the color is transparent and not themed. If we'll theme that as well, we'll have to update that as well.

Typo fix in revno 1327.

« Back to merge proposal