Code review comment for lp:~zsombi/ubuntu-ui-toolkit/20-divider
Revision history for this message
| Zsombor Egri (zsombi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> I'd venture to say that it should be an SDK design decision how much
> flexibility this has.
>
> While I can understand margins... thickness and either of color or gradient
> should go away. And even for gradient, I'd say we need back/foreground color
> instead of direct gradient.
Ok, you convinced me :) for now I've removed the thickness, but also the colours. I have a FIXME there to get the colors from the theme once we get the palette shaped to support colouring of the dividers. Yet, the colours are chosen based on the theme's normal background luminance.