Merge lp:~zsombi/address-book-app/bottomEdgeCollision into lp:address-book-app

Proposed by Zsombor Egri
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 515
Merged at revision: 518
Proposed branch: lp:~zsombi/address-book-app/bottomEdgeCollision
Merge into: lp:address-book-app
Diff against target: 51 lines (+6/-4)
2 files modified
src/imports/ABContactListPage.qml (+3/-1)
tests/qml/tst_ContactEditor.qml (+3/-3)
To merge this branch: bzr merge lp:~zsombi/address-book-app/bottomEdgeCollision
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Zoltan Balogh (community) Approve
Review via email: mp+279727@code.launchpad.net

Commit message

BottomEdge name collides with Ubuntu.Components 1.3 component name.

Description of the change

BottomEdge name collides with Ubuntu.Components 1.3 component name.

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

Does the job

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
516. By Zsombor Egri

adjust ActionBar button query

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/imports/ABContactListPage.qml'
--- src/imports/ABContactListPage.qml 2015-11-25 16:59:11 +0000
+++ src/imports/ABContactListPage.qml 2015-12-08 07:47:27 +0000
@@ -26,6 +26,8 @@
26import Ubuntu.AddressBook.Base 0.126import Ubuntu.AddressBook.Base 0.1
27import Ubuntu.AddressBook.ContactShare 0.127import Ubuntu.AddressBook.ContactShare 0.1
2828
29import "." as AB
30
29Page {31Page {
30 id: mainPage32 id: mainPage
31 objectName: "contactListPage"33 objectName: "contactListPage"
@@ -671,7 +673,7 @@
671 }673 }
672 }674 }
673675
674 BottomEdge {676 AB.BottomEdge {
675 id: bottomEdge677 id: bottomEdge
676 objectName: "bottomEdge"678 objectName: "bottomEdge"
677679
678680
=== modified file 'tests/qml/tst_ContactEditor.qml'
--- tests/qml/tst_ContactEditor.qml 2015-10-26 13:18:11 +0000
+++ tests/qml/tst_ContactEditor.qml 2015-12-08 07:47:27 +0000
@@ -69,7 +69,7 @@
6969
70 function init() {70 function init() {
71 waitForRendering(contactEditor);71 waitForRendering(contactEditor);
72 var saveButton = findChild(root, 'save_action_button');72 var saveButton = findChild(root, 'save_button');
73 compare(saveButton.enabled, false);73 compare(saveButton.enabled, false);
74 }74 }
7575
@@ -113,7 +113,7 @@
113 function test_fillRequiredFieldsMustEnableSaveButton(data) {113 function test_fillRequiredFieldsMustEnableSaveButton(data) {
114 var textField = findChild(root, data.objectName);114 var textField = findChild(root, data.objectName);
115 textField.text = 'test'115 textField.text = 'test'
116 var saveButton = findChild(root, 'save_action_button');116 var saveButton = findChild(root, 'save_button');
117 tryCompare(saveButton, 'enabled', true);117 tryCompare(saveButton, 'enabled', true);
118 }118 }
119119
@@ -125,7 +125,7 @@
125 function test_fillOptionalFieldsMustNotEnableSaveButton(data) {125 function test_fillOptionalFieldsMustNotEnableSaveButton(data) {
126 var textField = findChild(root, data.objectName);126 var textField = findChild(root, data.objectName);
127 textField.text = 'test'127 textField.text = 'test'
128 var saveButton = findChild(root, 'save_action_button');128 var saveButton = findChild(root, 'save_button');
129 tryCompare(saveButton, 'enabled', false);129 tryCompare(saveButton, 'enabled', false);
130 }130 }
131131

Subscribers

People subscribed via source and target branches