Code review comment for lp:~zorba-coders/zorba/zorba-error_printer_in_api
Revision history for this message
| Paul J. Lucas (paul-lucas) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I've done a lot of clean-up. You have the basic implementation correct. I've moved several functions inline. I've moved the printing of the stack trace constants to XQueryException since only XQueryException has stack traces. I've added doxygen comments that you didn't.
Why don't you include the "raised at" in the XML format?
Why don't you include the "applied at" in the XML format? (Not knowing what it is is not an acceptable reason.)
Why does ErrorPrinter need to exist at all? It seems redundant.