Code review comment for lp:~zorba-coders/zorba/xqdoc-extensions

Revision history for this message
David Graf (davidagraf) wrote :

> > > - The options schema uses a different modeling approach than all the
> others.
> > > It's not that all the others are consistent but this one seems to be
> > > introducing yet another way to model options, i.e. all as attributes of
> one
> > > element. Maybe we should make it consistent with at least one of the other
> > > option schemas.
> > I took this one because it's very compact. So, how should it be done. With
> > Jsoniq :-)? Or XML module style:
> > <opt:options>
> > <opt:enable component="function" />
> > <opt:enable component="index" />
> > </opt:options>
> I would do it the way the schema-tools-options or archive schemas do it (e.g.
> <opt:function>true</opt:function>). Alternatively, it could be done similar to
> the
> serialization options (e.g. <opt:function value="true"/>).
done

« Back to merge proposal