Code review comment for lp:~zorba-coders/zorba/util-jvm_core_module

Revision history for this message
Cezar Andrei (cezar-andrei) wrote :

Agreed, but we need to have them working before e check anything in.
 On May 1, 2013 5:31 PM, "Chris Hillery" <email address hidden>
wrote:

> Fixing ExternalModules.conf should be trivial.
>
> As to the other modules, we'll have to update them after merging this
> proposal. If we remove the FIND_PACKAGE() from them first, they'll have
> build errors. If we leave them as-is and merge this one first, then they
> will quietly get skipped by the remote queue, which is better. We'll just
> need to immediately commit changes to each of them after the main merge.
> --
>
> https://code.launchpad.net/~zorba-coders/zorba/util-jvm_core_module/+merge/161854
> You are reviewing the proposed merge of
> lp:~zorba-coders/zorba/util-jvm_core_module into lp:zorba.
>

« Back to merge proposal