Zorba

Code review comment for lp:~zorba-coders/zorba/util-jvm-rpath

  1. util-jvm-rpath
  2. Merge into module-util-jvm
Revision history for this message
Chris Hillery (ceejatec) wrote :

1. I believe that the correct values for RPATH are directories, not actual .so files, so the value of INSTALL_RPATH_PATHS should omit all the "/libjvm.so" parts.

2. FindJNI.cmake says:

# (To distribute this file outside of CMake, substitute the full
# License text for the above reference.)

So, we should do that.

review: Needs Fixing

« Back to merge proposal