Merge lp:~zorba-coders/zorba/update_format_integer_settings into lp:zorba

Proposed by Sorin Marian Nasoi
Status: Merged
Approved by: Sorin Marian Nasoi
Approved revision: 11309
Merged at revision: 11342
Proposed branch: lp:~zorba-coders/zorba/update_format_integer_settings
Merge into: lp:zorba
Diff against target: 80 lines (+16/-15)
2 files modified
test/fots/CMakeLists.txt (+3/-6)
test/fots_driver/FOTSZorbaManifest.xml (+13/-9)
To merge this branch: bzr merge lp:~zorba-coders/zorba/update_format_integer_settings
Reviewer Review Type Date Requested Status
Sorin Marian Nasoi Approve
Paul J. Lucas Approve
Review via email: mp+156702@code.launchpad.net

Commit message

Updated FOTSZorbaManifest.xml for the fn:format-integer.

Description of the change

Updated FOTSZorbaManifest.xml for the fn:format-integer.

To post a comment you must log in.
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job update_format_integer_settings-2013-04-02T22-33-40.069Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 1 Pending.

Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

Why is calendar CB set to true? Zorba doesn't support that calendar. Right now, we support only AD and ISO.

review: Needs Fixing
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) wrote :

> Why is calendar CB set to true? Zorba doesn't support that calendar. Right
> now, we support only AD and ISO.
Fixed: please note that there are 2 additional failures because the test cases are wrong in FOTS:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21558

Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Attempt to merge into lp:zorba failed due to conflicts:

text conflict in test/fots/CMakeLists.txt

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Attempt to merge into lp:zorba failed due to conflicts:

text conflict in test/fots/CMakeLists.txt

Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~zorba-coders/zorba/update_format_integer_settings into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message):
  Validation queue job
  update_format_integer_settings-2013-04-03T15-05-43.423Z is finished. The
  final status was:

  1 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

11308. By Sorin Marian Nasoi <email address hidden>

Merged lp:zorba trunk.

11309. By Sorin Marian Nasoi <email address hidden>

removed "EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-005 0)".

Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job update_format_integer_settings-2013-04-04T11-54-43.209Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt 2013-04-03 09:15:15 +0000
+++ test/fots/CMakeLists.txt 2013-04-04 11:54:31 +0000
@@ -103,9 +103,6 @@
103EXPECTED_FOTS_FAILURE (CRASH fn-matches.re re00976 1070533)103EXPECTED_FOTS_FAILURE (CRASH fn-matches.re re00976 1070533)
104EXPECTED_FOTS_FAILURE (CRASH fn-matches.re re00976a 1070533)104EXPECTED_FOTS_FAILURE (CRASH fn-matches.re re00976a 1070533)
105EXPECTED_FOTS_FAILURE (CRASH fn-unparsed-text-lines fn-unparsed-text-lines-052 1123835)105EXPECTED_FOTS_FAILURE (CRASH fn-unparsed-text-lines fn-unparsed-text-lines-052 1123835)
106EXPECTED_FOTS_FAILURE (CRASH prod-InstanceofExpr instanceof139 1160559) # failing but not crushing
107#EXPECTED_FOTS_FAILURE (CRASH prod-CastExpr.schema CastAs-UnionType-26 1160559)
108#EXPECTED_FOTS_FAILURE (CRASH prod-CastExpr.schema CastAs-UnionType-30 1160559)
109106
110# Next three possibly unique to old RQ machine, but they need to be107# Next three possibly unique to old RQ machine, but they need to be
111# marked for the RQ to pass.108# marked for the RQ to pass.
@@ -148,12 +145,11 @@
148EXPECTED_FOTS_FAILURE (fn-format-date format-date-en132 0)145EXPECTED_FOTS_FAILURE (fn-format-date format-date-en132 0)
149EXPECTED_FOTS_FAILURE (fn-format-date format-date-en133 0)146EXPECTED_FOTS_FAILURE (fn-format-date format-date-en133 0)
150EXPECTED_FOTS_FAILURE (fn-format-date format-date-en134 0)147EXPECTED_FOTS_FAILURE (fn-format-date format-date-en134 0)
148EXPECTED_FOTS_FAILURE (fn-format-date format-date-en152 21558)
151EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-006 0)149EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-006 0)
152EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-011 0)150EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-011 0)
151EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-en152 21558)
153EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-044 1162631)152EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-044 1162631)
154EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-049 0)
155EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-050 0)
156EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-052 0)
157EXPECTED_FOTS_FAILURE (fn-format-number numberformat14 0)153EXPECTED_FOTS_FAILURE (fn-format-number numberformat14 0)
158EXPECTED_FOTS_FAILURE (fn-format-number numberformat15 0)154EXPECTED_FOTS_FAILURE (fn-format-number numberformat15 0)
159EXPECTED_FOTS_FAILURE (fn-format-number numberformat34 0)155EXPECTED_FOTS_FAILURE (fn-format-number numberformat34 0)
@@ -437,6 +433,7 @@
437EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-029 0)433EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-029 0)
438EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-031 0)434EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-031 0)
439EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof113 0)435EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof113 0)
436EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof139 1160559)
440EXPECTED_FOTS_FAILURE (prod-InstanceofExpr cbcl-instance-of-001 0)437EXPECTED_FOTS_FAILURE (prod-InstanceofExpr cbcl-instance-of-001 0)
441EXPECTED_FOTS_FAILURE (prod-LetClause LetExpr020a 0)438EXPECTED_FOTS_FAILURE (prod-LetClause LetExpr020a 0)
442EXPECTED_FOTS_FAILURE (prod-Literal Literals056a 0)439EXPECTED_FOTS_FAILURE (prod-Literal Literals056a 0)
443440
=== modified file 'test/fots_driver/FOTSZorbaManifest.xml'
--- test/fots_driver/FOTSZorbaManifest.xml 2013-03-29 08:33:37 +0000
+++ test/fots_driver/FOTSZorbaManifest.xml 2013-04-04 11:54:31 +0000
@@ -35,26 +35,30 @@
35 <dependency type="xml-version" value="1.0:5+ 1.1" satisfied="false"/>35 <dependency type="xml-version" value="1.0:5+ 1.1" satisfied="false"/>
36 <dependency type="xml-version" value="1.1" satisfied="false"/>36 <dependency type="xml-version" value="1.1" satisfied="false"/>
3737
38 <dependency type="language" value="de" satisfied="false"/> <!-- Is this correct? -->38 <dependency type="language" value="de" satisfied="false"/>
39 <dependency type="language" value="en" satisfied="true"/>39 <dependency type="language" value="en" satisfied="true"/>
40 <dependency type="language" value="xib" satisfied="false"/> <!-- Is this correct? -->40 <dependency type="language" value="xib" satisfied="false"/>
4141
42 <!-- Are these correct? -->42 <dependency type="format-integer-sequence" value="Α" satisfied="false"/>
43 <dependency type="limits" value="year_lt_0" satisfied="true"/>43 <dependency type="format-integer-sequence" value="α" satisfied="false"/>
44 <dependency type="calendar" value="CB" satisfied="true"/>
45 <dependency type="format-integer-sequence" value="Α" satisfied="true"/>
46 <dependency type="format-integer-sequence" value="α" satisfied="true"/>
47 <dependency type="format-integer-sequence" value="١" satisfied="true"/>44 <dependency type="format-integer-sequence" value="١" satisfied="true"/>
48 <dependency type="format-integer-sequence" value="①" satisfied="true"/>45 <dependency type="format-integer-sequence" value="①" satisfied="true"/>
49 <dependency type="format-integer-sequence" value="⑴" satisfied="true"/>46 <dependency type="format-integer-sequence" value="⑴" satisfied="true"/>
50 <dependency type="format-integer-sequence" value="⒈" satisfied="true"/>47 <dependency type="format-integer-sequence" value="⒈" satisfied="true"/>
51 <dependency type="format-integer-sequence" value="一" satisfied="true"/>48 <dependency type="format-integer-sequence" value="一" satisfied="false"/>
52 <dependency type="format-integer-sequence" value="ﯴ" satisfied="true"/>49 <dependency type="format-integer-sequence" value="ﯴ" satisfied="false"/>
50
53 <dependency type="default-language" value="en" satisfied="true"/>51 <dependency type="default-language" value="en" satisfied="true"/>
54 <dependency type="unicode-normalization-form" value="FULLY-NORMALIZED" satisfied="true"/>52 <dependency type="unicode-normalization-form" value="FULLY-NORMALIZED" satisfied="true"/>
55 <dependency type="unicode-normalization-form" value="NFD" satisfied="true"/>53 <dependency type="unicode-normalization-form" value="NFD" satisfied="true"/>
56 <dependency type="unicode-normalization-form" value="NFKC" satisfied="true"/>54 <dependency type="unicode-normalization-form" value="NFKC" satisfied="true"/>
57 <dependency type="unicode-normalization-form" value="NFKD" satisfied="true"/>55 <dependency type="unicode-normalization-form" value="NFKD" satisfied="true"/>
56 <dependency type="calendar" value="CB" satisfied="false"/>
57
58 <dependency type="xsd-version" value="1.0" satisfied="false"/>58 <dependency type="xsd-version" value="1.0" satisfied="false"/>
59 <dependency type="xsd-version" value="1.1" satisfied="true"/>59 <dependency type="xsd-version" value="1.1" satisfied="true"/>
60
61
62 <!-- Are these correct? -->
63 <dependency type="limits" value="year_lt_0" satisfied="true"/>
60</test-suite-result>64</test-suite-result>

Subscribers

People subscribed via source and target branches