Merge lp:~zorba-coders/zorba/not-packaging-external-jars into lp:zorba

Proposed by Matthias Brantner
Status: Merged
Approved by: Matthias Brantner
Approved revision: 10868
Merged at revision: 10867
Proposed branch: lp:~zorba-coders/zorba/not-packaging-external-jars
Merge into: lp:zorba
Diff against target: 58 lines (+6/-7)
3 files modified
ChangeLog (+3/-0)
cmake_modules/ZorbaModule.cmake (+3/-3)
test/rbkt/modules/java/CMakeLists.txt (+0/-4)
To merge this branch: bzr merge lp:~zorba-coders/zorba/not-packaging-external-jars
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Chris Hillery Approve
Review via email: mp+107895@code.launchpad.net

Commit message

added a cmake variable that allows to configure whether external jars are packaged or not (ZORBA_PACKAGE_EXTERNAL_JARS)

Description of the change

- added a cmake variable that allows to configure whether external jars are packaged or not (ZORBA_PACKAGE_EXTERNAL_JARS)
- removed a test that started to fail if the ZORBA_PACKAGE_EXTERNAL_JARS variable is turned on. the test was actually cheating and didn't have an actual jar
- extended changelog for schema-tools and xsl-fo

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job not-packaging-external-jars-2012-05-30T01-18-06.466Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2012-05-23 16:11:13 +0000
+++ ChangeLog 2012-05-30 00:41:21 +0000
@@ -24,6 +24,8 @@
24 stream is seekable or not.24 stream is seekable or not.
25 * Added new functions in the fetch module and the StaticContext to fetch25 * Added new functions in the fetch module and the StaticContext to fetch
26 resources as binary26 resources as binary
27 * Added non-core schema-tools module for getting sample XMLSchema from
28 XML instances and sample XML instances from XMLSchema.
2729
28Optimizations:30Optimizations:
29 * optimized insertion into a collection (don't copy it if the node was31 * optimized insertion into a collection (don't copy it if the node was
@@ -64,6 +66,7 @@
64 * Fixed Bug #933490 (Error ItemFactoryImpl::createBase64Binary with istream)66 * Fixed Bug #933490 (Error ItemFactoryImpl::createBase64Binary with istream)
65 * Fixed bug #867112 (Diagnostic Handler was not working on external APIs)67 * Fixed bug #867112 (Diagnostic Handler was not working on external APIs)
66 * Fixed bug #857842 (Assertion failed with simple content element with comments)68 * Fixed bug #857842 (Assertion failed with simple content element with comments)
69 * Fixed bug #928626 (no setting classpath in xsl-fo module)
6770
68version 2.271version 2.2
6972
7073
=== modified file 'cmake_modules/ZorbaModule.cmake'
--- cmake_modules/ZorbaModule.cmake 2012-05-18 19:34:39 +0000
+++ cmake_modules/ZorbaModule.cmake 2012-05-30 00:41:21 +0000
@@ -481,16 +481,16 @@
481 # Iterate over all supplied jar files481 # Iterate over all supplied jar files
482 FOREACH (_jar_file ${JAR_FILE})482 FOREACH (_jar_file ${JAR_FILE})
483483
484 IF (JAR_EXTERNAL)484 IF (JAR_EXTERNAL AND NOT ZORBA_PACKAGE_EXTERNAL_JARS)
485 # Put absolute path into classpath file485 # Put absolute path into classpath file
486 FILE (APPEND "${_CP_FILE}" "${_jar_file}\n")486 FILE (APPEND "${_CP_FILE}" "${_jar_file}\n")
487 ELSE (JAR_EXTERNAL)487 ELSE (JAR_EXTERNAL AND NOT ZORBA_PACKAGE_EXTERNAL_JARS)
488 # Copy jar to jars/ directory and add relative path to classpath file488 # Copy jar to jars/ directory and add relative path to classpath file
489 GET_FILENAME_COMPONENT (_output_filename "${_jar_file}" NAME)489 GET_FILENAME_COMPONENT (_output_filename "${_jar_file}" NAME)
490 ADD_COPY_RULE ("LIB" "${_jar_file}" "jars/${_output_filename}" "" 490 ADD_COPY_RULE ("LIB" "${_jar_file}" "jars/${_output_filename}" ""
491 "${JAR_TARGET}" 1 "${JAR_TEST_ONLY}")491 "${JAR_TARGET}" 1 "${JAR_TEST_ONLY}")
492 FILE (APPEND "${_CP_FILE}" "${_output_filename}\n")492 FILE (APPEND "${_CP_FILE}" "${_output_filename}\n")
493 ENDIF (JAR_EXTERNAL)493 ENDIF (JAR_EXTERNAL AND NOT ZORBA_PACKAGE_EXTERNAL_JARS)
494494
495 ENDFOREACH (_jar_file)495 ENDFOREACH (_jar_file)
496ENDMACRO (DECLARE_ZORBA_JAR)496ENDMACRO (DECLARE_ZORBA_JAR)
497497
=== modified file 'test/rbkt/modules/java/CMakeLists.txt'
--- test/rbkt/modules/java/CMakeLists.txt 2012-04-05 11:48:50 +0000
+++ test/rbkt/modules/java/CMakeLists.txt 2012-05-30 00:41:21 +0000
@@ -32,9 +32,5 @@
32 DECLARE_ZORBA_JAR(FILE ${JavaTest_JAR_FILE} TARGET JavaTest TEST_ONLY)32 DECLARE_ZORBA_JAR(FILE ${JavaTest_JAR_FILE} TARGET JavaTest TEST_ONLY)
33 DECLARE_ZORBA_JAR(FILE ${JavaTest2_JAR_FILE} TARGET JavaTest2 TEST_ONLY)33 DECLARE_ZORBA_JAR(FILE ${JavaTest2_JAR_FILE} TARGET JavaTest2 TEST_ONLY)
3434
35 # Pretend to tell Zorba about some system jars
36 DECLARE_ZORBA_JAR(EXTERNAL FILE
37 "${PROJECT_SOURCE_DIR}/MyJar.jar" "${PROJECT_SOURCE_DIR}/MyJar2.jar")
38
39 ENDIF (Java_Development_FOUND)35 ENDIF (Java_Development_FOUND)
40ENDIF (${RESULT} GREATER -1)36ENDIF (${RESULT} GREATER -1)

Subscribers

People subscribed via source and target branches