Merge lp:~zorba-coders/zorba/mz-schema-tools-module into lp:zorba/schema-tools-module

Proposed by Markos Zaharioudakis
Status: Merged
Merged at revision: 42
Proposed branch: lp:~zorba-coders/zorba/mz-schema-tools-module
Merge into: lp:zorba/schema-tools-module
Diff against target: 65 lines (+8/-11)
1 file modified
src/schema-tools.xq.src/schema-tools.cpp (+8/-11)
To merge this branch: bzr merge lp:~zorba-coders/zorba/mz-schema-tools-module
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Review via email: mp+178620@code.launchpad.net

Commit message

XmlDataManager is not a singleton anymore

Description of the change

XmlDataManager is not a singleton anymore

To post a comment you must log in.
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/mz-schema-tools-module/+merge/178620

Stage "ZorbaVQ" failed.

Check console output at http://jenkins.lambda.nu/job/ZorbaVQ/218/console to view the results.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/schema-tools.xq.src/schema-tools.cpp'
2--- src/schema-tools.xq.src/schema-tools.cpp 2013-06-12 14:02:42 +0000
3+++ src/schema-tools.xq.src/schema-tools.cpp 2013-08-05 18:27:25 +0000
4@@ -57,13 +57,11 @@
5 private:
6 const ExternalModule* theModule;
7 ItemFactory* theFactory;
8- XmlDataManager* theDataManager;
9
10 public:
11 Inst2xsdFunction(const ExternalModule* aModule) :
12 theModule(aModule),
13- theFactory(Zorba::getInstance(0)->getItemFactory()),
14- theDataManager(Zorba::getInstance(0)->getXmlDataManager())
15+ theFactory(Zorba::getInstance(0)->getItemFactory())
16 {}
17
18 ~Inst2xsdFunction()
19@@ -77,23 +75,22 @@
20 { return "inst2xsd-internal"; }
21
22 virtual ItemSequence_t
23- evaluate(const ExternalFunction::Arguments_t& args,
24- const zorba::StaticContext*,
25- const zorba::DynamicContext*) const;
26+ evaluate(const ExternalFunction::Arguments_t& args,
27+ const zorba::StaticContext*,
28+ const zorba::DynamicContext*) const;
29 };
30
31+
32 class Xsd2instFunction : public ContextualExternalFunction
33 {
34 private:
35 const ExternalModule* theModule;
36 ItemFactory* theFactory;
37- XmlDataManager* theDataManager;
38
39 public:
40 Xsd2instFunction(const ExternalModule* aModule) :
41 theModule(aModule),
42- theFactory(Zorba::getInstance(0)->getItemFactory()),
43- theDataManager(Zorba::getInstance(0)->getXmlDataManager())
44+ theFactory(Zorba::getInstance(0)->getItemFactory())
45 {}
46
47 ~Xsd2instFunction()
48@@ -355,7 +352,7 @@
49 //std::cout << " lBinaryString '" << lBinaryString << "'" << std::endl; std::cout.flush();
50
51 std::stringstream lStream(lBinaryString);
52- Item lRes = theDataManager->parseXML(lStream);
53+ Item lRes = Zorba::getInstance(0)->getXmlDataManager()->parseXML(lStream);
54
55 vec.push_back(lRes);
56 }
57@@ -538,7 +535,7 @@
58 //std::cout << " lBinaryString '" << lBinaryString << "'" << std::endl; std::cout.flush();
59
60 std::stringstream lStream(lBinaryString);
61- Item lRes = theDataManager->parseXML(lStream);
62+ Item lRes = Zorba::getInstance(0)->getXmlDataManager()->parseXML(lStream);
63
64 return ItemSequence_t(new SingletonItemSequence(lRes));
65 }

Subscribers

People subscribed via source and target branches

to all changes: