Code review comment for lp:~zorba-coders/zorba/fn_envvars

Juan Zacarias (juan457) wrote :

> - the unparsed-text-lines function doesn't really stream because it
> materializes all the lines in a vector before returning them. Instead, the
> iterator should keep the istream in it's state and return the lines as they
> are parsed from the stream.
Just one question about this, the Item returned by the function for each line should be a Stream then?

« Back to merge proposal