Code review comment for lp:~zorba-coders/zorba/fn_envvars

Juan Zacarias (juan457) wrote :

> > > - It's unclear when the original stream for unparsed-text is released.
> This
> > > seems to be a memory leak.
> > for the original stream of unparsed-text which variable you mean?
> Yes, the stream you receive from the StreamResource contains a stream which is
> wrapped into a streamable string. The stream in the streamable string is
> released but the original one isn't. I think you need to remember it in a map
> and release it when the stream you created is released.

One more doubt regarding this, I got a little bit confused while trying to fix this, the one you mean is the stream that is inside the StreamResource, is the one that needs to be released right? since I had to set the StreamReleaser of it to a nullptr

« Back to merge proposal