Code review comment for lp:~zorba-coders/zorba/fn_envvars

Juan Zacarias (juan457) wrote :

I will make all those changes, Thanks.

and answering your questions

> - you can check using transcode::is_necessary if a encoding is supported
If I am not wrong I am using it that way.

> - What's the default encoding for unparsed-text?
UTF-8

The thing with the encoding is that the encoding is defined in the call of the function unparsed-text and unparsed-text-available being initialized with UTF-8 as a default, should I change the default definition to be inside readDocument function so that you don't have to defined in each function?

« Back to merge proposal