Code review comment for lp:~zorba-coders/zorba/fix_xqdoc_schema_import_prefix

Revision history for this message
Dana Florescu (dflorescu) wrote :

>>>
>> Yes, that's what I mean. It looks like the xqdoc visitor could crash with this
>> change. That's why I think the branch shouldn't be merged before it's tested.
> Nope, I disagree: this merge does not introduce the problem you mentioned because it was already there :)

I agree with Sorin. The problem was there already.

I think Sorin should go ahead and commit the change (at least the documentation will be usable..)
and then file a bug for the existing problem, and fix that after the release.

Thanks
Dana

« Back to merge proposal