Code review comment for lp:~zorba-coders/zorba/fix_warnings_fedora

Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

> > > > > - why were the spaces for the project names removed (e.g. ZorbaC-API
> =>
> > > Zorba
> > > > C-API)
> > > Also some details would help me understand your issues.
> > >
> > > FYI: the doxy.config.in were *not* updated by hand.
> > > I used doxygen -u doxy.config.in for every file in order to regenerate
> them
> > > using a more recent Doxygen version (1.7.5) and thus getting rid of the
> > > DEPRECATED warnings raised by "make doc".
> > The doxygen documentation says
> >
> > "The PROJECT_NAME tag is a single word (or a sequence of words surrounded by
> > double-quotes) that should identify the project for which the documentation
> is
> > generated. This name is used in the title of most generated pages and in a
> few
> > other places."
> >
> > So, I guess we should go for the old name surrounded by double-quotes.
> This would imply modifying the doxy.config.in files by hand, which IMHO is not
> a good idea.
> Next time we need to update them, "doxygen -u" will reveal the same issue: are
> you sure it's not a better solution to keep the actual names as generated
> automatically by Doxygen?
Initially, the file was edited by hand. Once the name is surrounded by quotes, the next update will take care of this automatically. It's just that it was buggy before because the name contained spaces.

« Back to merge proposal