Merge lp:~zorba-coders/zorba/fix_bug_1187807 into lp:zorba
- fix_bug_1187807
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Sorin Marian Nasoi |
Approved revision: | 11504 |
Merged at revision: | 11507 |
Proposed branch: | lp:~zorba-coders/zorba/fix_bug_1187807 |
Merge into: | lp:zorba |
Diff against target: |
228 lines (+45/-37) 3 files modified
test/fots/CMakeLists.txt (+4/-7) test/fots_driver/environment.xq (+16/-5) test/fots_driver/fots-driver.xq (+25/-25) |
To merge this branch: | bzr merge lp:~zorba-coders/zorba/fix_bug_1187807 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sorin Marian Nasoi | Approve | ||
Chris Hillery | Approve | ||
Review via email: mp+168681@code.launchpad.net |
Commit message
- temporary fix for lp:1187807: FOTS driver adds a base-uri in the prolog; the complete/clean fix requires lp:1133806 to be fixed.
Description of the change
- 11501. By sorin.marian.nasoi <email address hidden>
-
- fix for lp:1187807
- 11502. By sorin.marian.nasoi <email address hidden>
-
- updated LP bug numbers.
Sorin Marian Nasoi (sorin.marian.nasoi) : | # |
Zorba Build Bot (zorba-buildbot) wrote : | # |
Zorba Build Bot (zorba-buildbot) wrote : | # |
Validation queue job fix_bug_
All tests succeeded!
Zorba Build Bot (zorba-buildbot) wrote : | # |
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 1 Pending.
- 11503. By sorin.marian.nasoi <email address hidden>
-
- corrected LP byg number
Chris Hillery (ceejatec) : | # |
Sorin Marian Nasoi (sorin.marian.nasoi) : | # |
Zorba Build Bot (zorba-buildbot) wrote : | # |
Validation queue starting for merge proposal.
Log at: http://
Zorba Build Bot (zorba-buildbot) wrote : | # |
Validation queue job fix_bug_
All tests succeeded!
Preview Diff
1 | === modified file 'test/fots/CMakeLists.txt' | |||
2 | --- test/fots/CMakeLists.txt 2013-06-11 15:47:07 +0000 | |||
3 | +++ test/fots/CMakeLists.txt 2013-06-12 08:04:28 +0000 | |||
4 | @@ -129,6 +129,7 @@ | |||
5 | 129 | EXPECTED_FOTS_FAILURE (DISPUTED fn-format-dateTime format-dateTime-006 22282) | 129 | EXPECTED_FOTS_FAILURE (DISPUTED fn-format-dateTime format-dateTime-006 22282) |
6 | 130 | EXPECTED_FOTS_FAILURE (DISPUTED misc-XMLEdition XML10-4ed-Excluded-char-1 13869) | 130 | EXPECTED_FOTS_FAILURE (DISPUTED misc-XMLEdition XML10-4ed-Excluded-char-1 13869) |
7 | 131 | EXPECTED_FOTS_FAILURE (DISPUTED prod-ModuleImport modules-22 22317) | 131 | EXPECTED_FOTS_FAILURE (DISPUTED prod-ModuleImport modules-22 22317) |
8 | 132 | EXPECTED_FOTS_FAILURE (DISPUTED app-CatalogCheck Catalog011 22327) | ||
9 | 132 | 133 | ||
10 | 133 | # Next three possibly unique to old RQ machine, but they need to be | 134 | # Next three possibly unique to old RQ machine, but they need to be |
11 | 134 | # marked for the RQ to pass. | 135 | # marked for the RQ to pass. |
12 | @@ -140,8 +141,6 @@ | |||
13 | 140 | # This test passes on the old and new RQ machines, but fails for Sorin. | 141 | # This test passes on the old and new RQ machines, but fails for Sorin. |
14 | 141 | #EXPECTED_FOTS_FAILURE (fn-normalize-unicode fn-normalize-unicode-11 0) | 142 | #EXPECTED_FOTS_FAILURE (fn-normalize-unicode fn-normalize-unicode-11 0) |
15 | 142 | 143 | ||
16 | 143 | EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog010 1187807) | ||
17 | 144 | EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog011 1187807) | ||
18 | 145 | EXPECTED_FOTS_FAILURE (fn-fold-left fold-left-009 1187685) | 144 | EXPECTED_FOTS_FAILURE (fn-fold-left fold-left-009 1187685) |
19 | 146 | EXPECTED_FOTS_FAILURE (fn-for-each-pair fn-for-each-pair-026 1187685) | 145 | EXPECTED_FOTS_FAILURE (fn-for-each-pair fn-for-each-pair-026 1187685) |
20 | 147 | EXPECTED_FOTS_FAILURE (fn-format-number numberformat60a 1167609) | 146 | EXPECTED_FOTS_FAILURE (fn-format-number numberformat60a 1167609) |
21 | @@ -160,10 +159,8 @@ | |||
22 | 160 | EXPECTED_FOTS_FAILURE (fn-normalize-space fn-normalize-space-25 1187802) | 159 | EXPECTED_FOTS_FAILURE (fn-normalize-space fn-normalize-space-25 1187802) |
23 | 161 | EXPECTED_FOTS_FAILURE (fn-normalize-unicode cbcl-fn-normalize-unicode-001 1187813) | 160 | EXPECTED_FOTS_FAILURE (fn-normalize-unicode cbcl-fn-normalize-unicode-001 1187813) |
24 | 162 | EXPECTED_FOTS_FAILURE (fn-normalize-unicode cbcl-fn-normalize-unicode-006 1187813) | 161 | EXPECTED_FOTS_FAILURE (fn-normalize-unicode cbcl-fn-normalize-unicode-006 1187813) |
29 | 163 | EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-001 1187807) | 162 | EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-010 1189927) |
30 | 164 | EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-010 1188260) | 163 | EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-011 1188260) |
27 | 165 | EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-011 1187807) | ||
28 | 166 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-001 1187807) | ||
31 | 167 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-016 1188269) | 164 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-016 1188269) |
32 | 168 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-017 1188269) | 165 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-017 1188269) |
33 | 169 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-020 1188269) | 166 | EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-020 1188269) |
34 | @@ -218,7 +215,7 @@ | |||
35 | 218 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-8 1172270) | 215 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-8 1172270) |
36 | 219 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-9 1172270) | 216 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-9 1172270) |
37 | 220 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-10 1172270) | 217 | EXPECTED_FOTS_FAILURE (prod-Annotation annotation-assertion-10 1172270) |
39 | 221 | EXPECTED_FOTS_FAILURE (prod-BaseURIDecl K2-BaseURIProlog-5 1187807) | 218 | EXPECTED_FOTS_FAILURE (prod-BaseURIDecl K2-BaseURIProlog-5 1133806) |
40 | 222 | EXPECTED_FOTS_FAILURE (prod-CastableExpr K-SeqExprCastable-5a 1188281) | 219 | EXPECTED_FOTS_FAILURE (prod-CastableExpr K-SeqExprCastable-5a 1188281) |
41 | 223 | EXPECTED_FOTS_FAILURE (prod-CastExpr CastAsNamespaceSensitiveType-11 1188279) | 220 | EXPECTED_FOTS_FAILURE (prod-CastExpr CastAsNamespaceSensitiveType-11 1188279) |
42 | 224 | EXPECTED_FOTS_FAILURE (prod-CastExpr CastAsNamespaceSensitiveType-12 1188279) | 221 | EXPECTED_FOTS_FAILURE (prod-CastExpr CastAsNamespaceSensitiveType-12 1188279) |
43 | 225 | 222 | ||
44 | === modified file 'test/fots_driver/environment.xq' | |||
45 | --- test/fots_driver/environment.xq 2013-05-17 23:57:15 +0000 | |||
46 | +++ test/fots_driver/environment.xq 2013-06-12 08:04:28 +0000 | |||
47 | @@ -82,16 +82,27 @@ | |||
48 | 82 | : @param $env the non-local environment of the test-case, if any. It is an | 82 | : @param $env the non-local environment of the test-case, if any. It is an |
49 | 83 | : environment specified either at the test-set level or at the catalog | 83 | : environment specified either at the test-set level or at the catalog |
50 | 84 | : level and is referenced by the test-case. | 84 | : level and is referenced by the test-case. |
51 | 85 | : @param $test the raw query text. | ||
52 | 86 | : @param $testSetURI the URI of the directory that contains the file of the | ||
53 | 87 | : associated test-set. | ||
54 | 85 | : @param $envCase the local environment of the test-case, if any. | 88 | : @param $envCase the local environment of the test-case, if any. |
55 | 86 | : @return the declare base-uri prolog statement. | 89 | : @return the declare base-uri prolog statement. |
56 | 87 | :) | 90 | :) |
57 | 88 | declare function env:decl-base-uri( | 91 | declare function env:decl-base-uri( |
60 | 89 | $env as element(fots:environment)?, | 92 | $env as element(fots:environment)?, |
61 | 90 | $envCase as element(fots:environment)? | 93 | $envCase as element(fots:environment)?, |
62 | 94 | $test as xs:string, | ||
63 | 95 | $testSetURI as xs:anyURI | ||
64 | 91 | ) as xs:string? | 96 | ) as xs:string? |
65 | 92 | { | 97 | { |
68 | 93 | for $baseURI in ($env/fots:static-base-uri, $envCase/fots:static-base-uri) | 98 | if($env/fots:static-base-uri, $envCase/fots:static-base-uri) then |
69 | 94 | return concat("declare base-uri '", $baseURI/@uri, "';") | 99 | for $baseURI in ($env/fots:static-base-uri, $envCase/fots:static-base-uri) |
70 | 100 | return concat('declare base-uri "', $baseURI/@uri, '";') | ||
71 | 101 | else if(not(contains($test,"declare base-uri ") or | ||
72 | 102 | contains($test,"xquery version ") or | ||
73 | 103 | contains($test,"declare(::)base-uri"))) then | ||
74 | 104 | concat('declare base-uri "', $testSetURI, '";') | ||
75 | 105 | else () | ||
76 | 95 | }; | 106 | }; |
77 | 96 | 107 | ||
78 | 97 | 108 | ||
79 | @@ -161,7 +172,7 @@ | |||
80 | 161 | $test as xs:string | 172 | $test as xs:string |
81 | 162 | ) as xs:boolean | 173 | ) as xs:boolean |
82 | 163 | { | 174 | { |
84 | 164 | contains($test, concat("import schema namespace ", $prefix)) | 175 | contains($test, concat('import schema namespace ', $prefix)) |
85 | 165 | }; | 176 | }; |
86 | 166 | 177 | ||
87 | 167 | 178 | ||
88 | 168 | 179 | ||
89 | === modified file 'test/fots_driver/fots-driver.xq' | |||
90 | --- test/fots_driver/fots-driver.xq 2013-05-17 23:57:15 +0000 | |||
91 | +++ test/fots_driver/fots-driver.xq 2013-06-12 08:04:28 +0000 | |||
92 | @@ -822,8 +822,8 @@ | |||
93 | 822 | : @param $deps the dependencies that should be checked for given test-case. | 822 | : @param $deps the dependencies that should be checked for given test-case. |
94 | 823 | : These may be defined at test-set level and/or test-case level. | 823 | : These may be defined at test-set level and/or test-case level. |
95 | 824 | : @param $testSetName the name of the test-set. | 824 | : @param $testSetName the name of the test-set. |
98 | 825 | : @param $testSetBaseURI the URI of the directory that contains the file of the | 825 | : @param $testSetURI the URI of the directory that contains the file of the |
99 | 826 | associated test-set. | 826 | : associated test-set. |
100 | 827 | : @param $verbose if true, the resulting XML tree will contain more details | 827 | : @param $verbose if true, the resulting XML tree will contain more details |
101 | 828 | : about the test-case. | 828 | : about the test-case. |
102 | 829 | : @param $expFailureTC the 'Test' element from the ExpectedFailures.xml file. | 829 | : @param $expFailureTC the 'Test' element from the ExpectedFailures.xml file. |
103 | @@ -834,17 +834,17 @@ | |||
104 | 834 | : @return an XML tree containing the result of running the test-case. | 834 | : @return an XML tree containing the result of running the test-case. |
105 | 835 | :) | 835 | :) |
106 | 836 | declare %private %ann:sequential function driver:run-test-case( | 836 | declare %private %ann:sequential function driver:run-test-case( |
118 | 837 | $case as element(fots:test-case), | 837 | $case as element(fots:test-case), |
119 | 838 | $env as element(fots:environment)?, | 838 | $env as element(fots:environment)?, |
120 | 839 | $envBaseURI as xs:anyURI?, | 839 | $envBaseURI as xs:anyURI?, |
121 | 840 | $deps as element(fots:dependency)*, | 840 | $deps as element(fots:dependency)*, |
122 | 841 | $testSetName as xs:string, | 841 | $testSetName as xs:string, |
123 | 842 | $testSetBaseURI as xs:anyURI, | 842 | $testSetURI as xs:anyURI, |
124 | 843 | $verbose as xs:boolean, | 843 | $verbose as xs:boolean, |
125 | 844 | $expFailureTC as element(Test)?, | 844 | $expFailureTC as element(Test)?, |
126 | 845 | $ctestMode as xs:boolean, | 845 | $ctestMode as xs:boolean, |
127 | 846 | $cliMode as xs:string, | 846 | $cliMode as xs:string, |
128 | 847 | $usePlanSerializer as xs:boolean | 847 | $usePlanSerializer as xs:boolean |
129 | 848 | ) as element(fots:test-case)? | 848 | ) as element(fots:test-case)? |
130 | 849 | { | 849 | { |
131 | 850 | (:TODO Cover the "(:%VARDECL%:)"when there are tests in FOTS that use it:) | 850 | (:TODO Cover the "(:%VARDECL%:)"when there are tests in FOTS that use it:) |
132 | @@ -858,7 +858,7 @@ | |||
133 | 858 | 858 | ||
134 | 859 | variable $queryName := $case/@name; | 859 | variable $queryName := $case/@name; |
135 | 860 | 860 | ||
137 | 861 | variable $test as xs:string := util:get-value($case, $testSetBaseURI, "test"); | 861 | variable $test as xs:string := util:get-value($case, $testSetURI, "test"); |
138 | 862 | 862 | ||
139 | 863 | variable $envCase := $case/fots:environment; | 863 | variable $envCase := $case/fots:environment; |
140 | 864 | 864 | ||
141 | @@ -868,7 +868,7 @@ | |||
142 | 868 | ( | 868 | ( |
143 | 869 | env:add-xquery-version-decl(($deps, $case//fots:dependency), $test), | 869 | env:add-xquery-version-decl(($deps, $case//fots:dependency), $test), |
144 | 870 | 870 | ||
146 | 871 | env:decl-base-uri($env, $envCase), | 871 | env:decl-base-uri($env, $envCase, $test, $testSetURI), |
147 | 872 | 872 | ||
148 | 873 | env:decl-def-elem-namespace($env, $envCase), | 873 | env:decl-def-elem-namespace($env, $envCase), |
149 | 874 | 874 | ||
150 | @@ -877,7 +877,7 @@ | |||
151 | 877 | env:decl-decimal-formats(($env/fots:decimal-format, | 877 | env:decl-decimal-formats(($env/fots:decimal-format, |
152 | 878 | $envCase/fots:decimal-format)), | 878 | $envCase/fots:decimal-format)), |
153 | 879 | 879 | ||
155 | 880 | env:add-var-decl($env, $envCase, $envBaseURI, $testSetBaseURI), | 880 | env:add-var-decl($env, $envCase, $envBaseURI, $testSetURI), |
156 | 881 | 881 | ||
157 | 882 | $test | 882 | $test |
158 | 883 | ), | 883 | ), |
159 | @@ -888,7 +888,7 @@ | |||
160 | 888 | $case, | 888 | $case, |
161 | 889 | $env, | 889 | $env, |
162 | 890 | $envBaseURI, | 890 | $envBaseURI, |
164 | 891 | $testSetBaseURI, | 891 | $testSetURI, |
165 | 892 | $deps); | 892 | $deps); |
166 | 893 | 893 | ||
167 | 894 | (:if $verbose then print the query to a file:) | 894 | (:if $verbose then print the query to a file:) |
168 | @@ -902,7 +902,7 @@ | |||
169 | 902 | variable $result := execute:xqxq-invoke($xqxqQuery, | 902 | variable $result := execute:xqxq-invoke($xqxqQuery, |
170 | 903 | $case, | 903 | $case, |
171 | 904 | $verbose, | 904 | $verbose, |
173 | 905 | $testSetBaseURI, | 905 | $testSetURI, |
174 | 906 | $usePlanSerializer); | 906 | $usePlanSerializer); |
175 | 907 | 907 | ||
176 | 908 | variable $duration := (datetime:current-dateTime() - $startDateTime); | 908 | variable $duration := (datetime:current-dateTime() - $startDateTime); |
177 | @@ -953,7 +953,7 @@ | |||
178 | 953 | $case/fots:result/*, | 953 | $case/fots:result/*, |
179 | 954 | $err:code, | 954 | $err:code, |
180 | 955 | $err:description, | 955 | $err:description, |
182 | 956 | $testSetBaseURI), | 956 | $testSetURI), |
183 | 957 | "fots-driver.xq:driver:test catch", | 957 | "fots-driver.xq:driver:test catch", |
184 | 958 | $testSetName, | 958 | $testSetName, |
185 | 959 | $env, | 959 | $env, |
186 | @@ -975,7 +975,7 @@ | |||
187 | 975 | : @param $case the test case. | 975 | : @param $case the test case. |
188 | 976 | : @param $env the environment. | 976 | : @param $env the environment. |
189 | 977 | : @param $envBaseURI URI of the environment. | 977 | : @param $envBaseURI URI of the environment. |
191 | 978 | : @param $testSetBaseURI the URI of the directory that contains the file of the | 978 | : @param $testSetURI the URI of the directory that contains the file of the |
192 | 979 | : associated test set. | 979 | : associated test set. |
193 | 980 | : @param $deps the dependencies that should be checked for given test-case. | 980 | : @param $deps the dependencies that should be checked for given test-case. |
194 | 981 | : These may be defined at test-set level and/or test-case level. | 981 | : These may be defined at test-set level and/or test-case level. |
195 | @@ -986,18 +986,18 @@ | |||
196 | 986 | $case as element(fots:test-case), | 986 | $case as element(fots:test-case), |
197 | 987 | $env as element(fots:environment)?, | 987 | $env as element(fots:environment)?, |
198 | 988 | $envBaseURI as xs:anyURI?, | 988 | $envBaseURI as xs:anyURI?, |
200 | 989 | $testSetBaseURI as xs:anyURI, | 989 | $testSetURI as xs:anyURI, |
201 | 990 | $deps as element(fots:dependency)* | 990 | $deps as element(fots:dependency)* |
202 | 991 | ) as xs:string | 991 | ) as xs:string |
203 | 992 | { | 992 | { |
204 | 993 | let $resolver as xs:string? := env:resolver($case, | 993 | let $resolver as xs:string? := env:resolver($case, |
205 | 994 | $env, | 994 | $env, |
206 | 995 | $envBaseURI, | 995 | $envBaseURI, |
208 | 996 | $testSetBaseURI) | 996 | $testSetURI) |
209 | 997 | let $mapper as xs:string? := env:mapper($case, | 997 | let $mapper as xs:string? := env:mapper($case, |
210 | 998 | $env, | 998 | $env, |
211 | 999 | $envBaseURI, | 999 | $envBaseURI, |
213 | 1000 | $testSetBaseURI) | 1000 | $testSetURI) |
214 | 1001 | let $needsDTDValidation := exists($deps[@type="feature" and @value="infoset-dtd"]) | 1001 | let $needsDTDValidation := exists($deps[@type="feature" and @value="infoset-dtd"]) |
215 | 1002 | return | 1002 | return |
216 | 1003 | string-join | 1003 | string-join |
217 | @@ -1063,9 +1063,9 @@ | |||
218 | 1063 | else "
);"), | 1063 | else "
);"), |
219 | 1064 | 1064 | ||
220 | 1065 | env:set-context-item($env, $envBaseURI, $needsDTDValidation), | 1065 | env:set-context-item($env, $envBaseURI, $needsDTDValidation), |
222 | 1066 | env:set-context-item($case/fots:environment, $testSetBaseURI, $needsDTDValidation), | 1066 | env:set-context-item($case/fots:environment, $testSetURI, $needsDTDValidation), |
223 | 1067 | env:set-variables($env, $envBaseURI), | 1067 | env:set-variables($env, $envBaseURI), |
225 | 1068 | env:set-variables($case/fots:environment, $testSetBaseURI), | 1068 | env:set-variables($case/fots:environment, $testSetURI), |
226 | 1069 | 1069 | ||
227 | 1070 | "xqxq:evaluate($queryID),", | 1070 | "xqxq:evaluate($queryID),", |
228 | 1071 | "", | 1071 | "", |
Validation queue starting for merge proposal. zorbatest. lambda. nu:8080/ remotequeue/ fix_bug_ 1187807- 2013-06- 11T14-55- 55.909Z/ log.html
Log at: http://