Merge lp:~zorba-coders/zorba/fix-random-annotation into lp:zorba

Proposed by Federico Cavalieri on 2013-12-19
Status: Merged
Merged at revision: 11680
Proposed branch: lp:~zorba-coders/zorba/fix-random-annotation
Merge into: lp:zorba
Diff against target: 24 lines (+2/-1)
2 files modified
src/functions/pregenerated/func_random.h (+1/-0)
src/runtime/spec/random/random.xml (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/fix-random-annotation
Reviewer Review Type Date Requested Status
Federico Cavalieri Approve on 2013-12-20
Matthias Brantner 2013-12-19 Approve on 2013-12-20
Review via email: mp+199706@code.launchpad.net

Commit message

Fixed random#0 function annotation.

Description of the change

Fixed random#0 function annotation.

To post a comment you must log in.
Zorba Build Bot (zorba-buildbot) wrote :
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706

Stage "TestZorbaUbuntu" failed.
1 tests failed (8751 total tests run).

Check test results at http://jenkins.lambda.nu:8180/job/TestZorbaUbuntu/419/testReport/ to view the results.

11680. By Federico Cavalieri on 2013-12-19

Fixed func_random.h

Zorba Build Bot (zorba-buildbot) wrote :
Zorba Build Bot (zorba-buildbot) wrote :

Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706 :
Votes: {'Pending': 1}

Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706

Stage "CommitZorba" failed.

Check console output at http://jenkins.lambda.nu:8180/job/CommitZorba/261/console to view the results.

review: Approve
Zorba Build Bot (zorba-buildbot) wrote :
Zorba Build Bot (zorba-buildbot) wrote :

Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706 :
Votes: {'Approve': 1}

Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706

Stage "CommitZorba" failed.

Check console output at http://jenkins.lambda.nu:8180/job/CommitZorba/263/console to view the results.

review: Approve
Zorba Build Bot (zorba-buildbot) wrote :
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/functions/pregenerated/func_random.h'
2--- src/functions/pregenerated/func_random.h 2013-03-05 23:11:50 +0000
3+++ src/functions/pregenerated/func_random.h 2013-12-19 19:35:48 +0000
4@@ -61,6 +61,7 @@
5 :
6 function(sig, kind)
7 {
8+setDeterministic(false);
9
10 }
11
12
13=== modified file 'src/runtime/spec/random/random.xml'
14--- src/runtime/spec/random/random.xml 2013-05-08 20:14:47 +0000
15+++ src/runtime/spec/random/random.xml 2013-12-19 19:35:48 +0000
16@@ -59,7 +59,7 @@
17 <zorba:member type="xs_integer" name="theCurrCounter" brief=""/>
18 </zorba:state>
19
20- <zorba:function isDeterministic="true">
21+ <zorba:function isDeterministic="false">
22
23 <zorba:signature localname="random" prefix="fn-zorba-random">
24 <zorba:param>xs:integer</zorba:param> <!-- num of number to be genreated -->

Subscribers

People subscribed via source and target branches