Code review comment for lp:~zorba-coders/zorba/feature-uuid

Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

> > 1. Are the things you compile/link against on Windows and Mac guaranteed to
> > exist? (ie, do I only need to find libuuid on Linux platforms)
>
> Yes.
>
> > 2. What should happen if I *don't* find it? Can the UUID code be made
> optional
> > at compile time? Would that mean we need a ZORBA_WITH_UUID or something like
> > that? Or, do we have a hard requirement on libuuid and the build should fail
> > without it?
>
> I think it has to be the latter, but Matthias might know.
I think it should be a hard requirement. UUID functionality comes with Windows and Mac. On Linux, the library should always be available. Also, as far as I understood, we already depended on libuuid before.

« Back to merge proposal