Merge lp:~zorba-coders/zorba/disable_assert-invariant into lp:zorba

Proposed by Matthias Brantner
Status: Merged
Approved by: Matthias Brantner
Approved revision: 11607
Merged at revision: 11632
Proposed branch: lp:~zorba-coders/zorba/disable_assert-invariant
Merge into: lp:zorba
Diff against target: 12 lines (+1/-1)
1 file modified
src/store/naive/json_items.h (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/disable_assert-invariant
Reviewer Review Type Date Requested Status
Ghislain Fourny Approve
Matthias Brantner Approve
Review via email: mp+182971@code.launchpad.net

Commit message

  disable ASSERT_INVARIANT always (not only if NDEBUG is set). The problem with this
  is that it depends on the CMake version whether NDEBUG is set in RelWithDebInfo.
  This might cause unexpected slow queries with some CMake versions.

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Ghislain Fourny (gislenius) :
review: Approve
Revision history for this message
Cristian Dumitru (cdumitru) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/store/naive/json_items.h'
2--- src/store/naive/json_items.h 2013-06-05 00:37:35 +0000
3+++ src/store/naive/json_items.h 2013-08-29 17:56:31 +0000
4@@ -472,7 +472,7 @@
5 };
6
7
8-#ifndef NDEBUG
9+#if 0
10 #define ASSERT_INVARIANT() assertInvariant()
11 #else
12 #define ASSERT_INVARIANT()

Subscribers

People subscribed via source and target branches