Merge lp:~zorba-coders/zorba/csharp-win-installer-fix into lp:zorba

Proposed by Juan Zacarias
Status: Merged
Approved by: Rodolfo Ochoa
Approved revision: 10971
Merged at revision: 10974
Proposed branch: lp:~zorba-coders/zorba/csharp-win-installer-fix
Merge into: lp:zorba
Diff against target: 76 lines (+12/-5)
3 files modified
CMakeCPack.cmake (+5/-2)
doc/CMakeLists.txt (+4/-0)
swig/csharp/CMakeLists.txt (+3/-3)
To merge this branch: bzr merge lp:~zorba-coders/zorba/csharp-win-installer-fix
Reviewer Review Type Date Requested Status
Rodolfo Ochoa Approve
Chris Hillery Approve
Review via email: mp+118212@code.launchpad.net

Commit message

Fixed windows installer component options for c# Bindings

To post a comment you must log in.
10970. By Juan Zacarias

Windows Installer change: Added thesaurus and csharp Bindings to Full installation type

Revision history for this message
Chris Hillery (ceejatec) wrote :

Changes look good, but can you revert the line-endings change to NOTICE.xml?

review: Needs Fixing
Revision history for this message
Chris Hillery (ceejatec) wrote :

Er, NOTICE.txt, that is.

10971. By Juan Zacarias

reverted change on NOTICE.txt

Revision history for this message
Juan Zacarias (juan457) wrote :

> Er, NOTICE.txt, that is.
Fixed

Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Rodolfo Ochoa (rodolfo-ochoa) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job csharp-win-installer-fix-2012-08-06T22-59-02.344Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeCPack.cmake'
--- CMakeCPack.cmake 2012-08-03 04:35:01 +0000
+++ CMakeCPack.cmake 2012-08-06 17:21:38 +0000
@@ -33,6 +33,7 @@
33SET(CPACK_COMPONENT_RUBY_SWIG_DISPLAY_NAME "Ruby API")33SET(CPACK_COMPONENT_RUBY_SWIG_DISPLAY_NAME "Ruby API")
34SET(CPACK_COMPONENT_XQJ_SWIG_DISPLAY_NAME "Java XQJ API")34SET(CPACK_COMPONENT_XQJ_SWIG_DISPLAY_NAME "Java XQJ API")
35SET(CPACK_COMPONENT_THESAURUS_DISPLAY_NAME "Thesaurus")35SET(CPACK_COMPONENT_THESAURUS_DISPLAY_NAME "Thesaurus")
36SET(CPACK_COMPONENT_CSHARP_SWIG_DISPLAY_NAME "C# API")
3637
37SET(CPACK_COMPONENT_UNSPECIFIED_DESCRIPTION "Zorba Required Files.")38SET(CPACK_COMPONENT_UNSPECIFIED_DESCRIPTION "Zorba Required Files.")
38SET(CPACK_COMPONENT_DOC_DESCRIPTION "Files with the Description of different features of zorba.")39SET(CPACK_COMPONENT_DOC_DESCRIPTION "Files with the Description of different features of zorba.")
@@ -46,6 +47,7 @@
46SET(CPACK_COMPONENT_RUBY_SWIG_DESCRIPTION "API for Ruby")47SET(CPACK_COMPONENT_RUBY_SWIG_DESCRIPTION "API for Ruby")
47SET(CPACK_COMPONENT_XQJ_SWIG_DESCRIPTION "XQJ API for Java")48SET(CPACK_COMPONENT_XQJ_SWIG_DESCRIPTION "XQJ API for Java")
48SET(CPACK_COMPONENT_THESAURUS_DESCRIPTION "Thesaurus for Zorba")49SET(CPACK_COMPONENT_THESAURUS_DESCRIPTION "Thesaurus for Zorba")
50SET(CPACK_COMPONENT_CSHARP_SWIG_DESCRIPTION "API for C#")
4951
50SET(CPACK_COMPONENT_DOC_GROUP "Documents")52SET(CPACK_COMPONENT_DOC_GROUP "Documents")
51SET(CPACK_COMPONENT_PHP_EXAMPLES_GROUP "Documents")53SET(CPACK_COMPONENT_PHP_EXAMPLES_GROUP "Documents")
@@ -58,6 +60,7 @@
58SET(CPACK_COMPONENT_PYTHON_SWIG_GROUP "APIs")60SET(CPACK_COMPONENT_PYTHON_SWIG_GROUP "APIs")
59SET(CPACK_COMPONENT_RUBY_SWIG_GROUP "APIs")61SET(CPACK_COMPONENT_RUBY_SWIG_GROUP "APIs")
60SET(CPACK_COMPONENT_XQJ_SWIG_GROUP "APIs")62SET(CPACK_COMPONENT_XQJ_SWIG_GROUP "APIs")
63SET(CPACK_COMPONENT_CSHARP_SWIG_GROUP "APIs")
6164
62SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DISPLAY_NAME "External Modules")65SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DISPLAY_NAME "External Modules")
63SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DESCRIPTION "Complete list of external modules.")66SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DESCRIPTION "Complete list of external modules.")
@@ -77,8 +80,8 @@
77SET(CPACK_COMPONENT_RUBY_SWIG_INSTALL_TYPES Full)80SET(CPACK_COMPONENT_RUBY_SWIG_INSTALL_TYPES Full)
78SET(CPACK_COMPONENT_XQJ_SWIG_INSTALL_TYPES Full)81SET(CPACK_COMPONENT_XQJ_SWIG_INSTALL_TYPES Full)
79SET(CPACK_COMPONENT_UNSPECIFIED_INSTALL_TYPES Full Simple Lite)82SET(CPACK_COMPONENT_UNSPECIFIED_INSTALL_TYPES Full Simple Lite)
80SET(CPACK_COMPONENT_THESAURUS_INSTALL_TYPE Full)83SET(CPACK_COMPONENT_THESAURUS_INSTALL_TYPES Full)
8184SET(CPACK_COMPONENT_CSHARP_SWIG_INSTALL_TYPES Full)
8285
83INCLUDE(${CMAKE_BINARY_DIR}/CMakeCPackModules.cmake)86INCLUDE(${CMAKE_BINARY_DIR}/CMakeCPackModules.cmake)
8487
8588
=== modified file 'doc/CMakeLists.txt'
--- doc/CMakeLists.txt 2012-07-30 20:09:08 +0000
+++ doc/CMakeLists.txt 2012-08-06 17:21:38 +0000
@@ -97,6 +97,10 @@
97 INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/xqj/html 97 INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/xqj/html
98 COMPONENT "doc"98 COMPONENT "doc"
99 DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/xqj)99 DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/xqj)
100
101 INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/csharp/html
102 COMPONENT "doc"
103 DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/csharp)
100ENDIF (SWIG_FOUND)104ENDIF (SWIG_FOUND)
101105
102INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/zorba/html 106INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/zorba/html
103107
=== modified file 'swig/csharp/CMakeLists.txt'
--- swig/csharp/CMakeLists.txt 2012-07-30 20:09:08 +0000
+++ swig/csharp/CMakeLists.txt 2012-08-06 17:21:38 +0000
@@ -38,16 +38,16 @@
38 IF (MSVC_IDE)38 IF (MSVC_IDE)
39 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/zorba_api.dll 39 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/zorba_api.dll
40 DESTINATION share/csharp40 DESTINATION share/csharp
41 COMPONENT "C# Bindings ")41 COMPONENT csharp_swig)
42 ELSE (MSVC_IDE)42 ELSE (MSVC_IDE)
43 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_api.dll 43 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_api.dll
44 DESTINATION share/csharp44 DESTINATION share/csharp
45 COMPONENT "C# Bindings ")45 COMPONENT csharp_swig)
46 ENDIF (MSVC_IDE)46 ENDIF (MSVC_IDE)
47 47
48 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_csharp.dll 48 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_csharp.dll
49 DESTINATION share/csharp49 DESTINATION share/csharp
50 COMPONENT "C# Bindings ")50 COMPONENT csharp_swig)
5151
52 ADD_SUBDIRECTORY (tests) 52 ADD_SUBDIRECTORY (tests)
53 53

Subscribers

People subscribed via source and target branches