Code review comment for lp:~zorba-coders/zorba/bug905035

Revision history for this message
Markos Zaharioudakis (markos-za) wrote :

Matthias, the getNamespaceBindings method is rather inefficient as it will copy the actual strings twice. And it should also pre-allocated the space for the returned vector. I don't think this is going to be a major bottleneck, so I have approved the proposal. But in the spirit of "best practices", it is better if it is fixed.

« Back to merge proposal