Zorba

Code review comment for lp:~zorba-coders/zorba/bug1123016

  1. bug1123016
  2. Merge into trunk
Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

- nice job
- comments of the functions in xqxq.xq are missing
- std::stringstream* lExcPlan = new std::stringstream();
  will leak if saveExecutionPlan returns false or raises an error. You should use an auto_ptr or something similar
- Chris do you have ideas for better/nicer function names?

review: Needs Fixing

« Back to merge proposal