Code review comment for lp:~zorba-coders/zorba/bug1082740_fn_subsequence

Revision history for this message
Chris Hillery (ceejatec) wrote :

I agree with your logic, Juan; thanks for spelling it out. I hadn't realized that your new flag were not checked in the inner loop of fn:subsequence(), but looking at the implementation it appears that is the case. So I have no problem with it.

Voting Approve now, although clearly the two failing FOTS tests will need to be addressed before it will merge.

review: Approve

« Back to merge proposal