Code review comment for lp:~zorba-coders/zorba/bug-867376

Revision history for this message
Luis Rodriguez Gonzalez (kuraru) wrote :

> > I will include the 3 different errors for uri:serialize(), Should I leave
> > uri:parse() without any error code?
>
> I'm sure there are some reasonable errors for uri:parse(), but I'm not totally
> sure what they might be. It's possible that URI.cpp will already throw some
> exceptions if you try to parse a bogus URI, and that might well be good
> enough.
>
> Matthias, can you think of any specific error cases that we should test out?
Actually you are right, the current underlying library throws some exceptions already.

« Back to merge proposal