Code review comment for lp:~zorba-coders/zorba/bug-867376

Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

- Why is there a schema imported in uri.xq? I don't think it's needed anymore.
- The documentation should say what types of errors the function can raise.
- It would be nice to have constants for the names of the fields in the objects (e.g. scheme, opaque-part)
- Why does the change comment out all language bindings in swig/CMakeLists.txt and test/rbkt/modules/CMakeLists.txt?

review: Needs Fixing

« Back to merge proposal