Code review comment for lp:~zorba-coders/zorba/bug-867363-disable-http

> > 1. I don't see the zorba cmd doing anything with the --disable-http-
> resolution
> > option, if that option is actually specified in the command line.
>
> See the second diff in zorbacmdproperties_base.h. It just explicitly sets the
> disable-http-resolution option on the static context by using the same code as
> --option.
>

Ok, I got it. But the actual update of the static context is not done in zorbacmdproperties_base.h; it is done in zorbacmd.cpp:179.

>
> > 2. If a user uses the option inside an xquery module, it will have no effect
> > because options are processed after the imports. Such a user will then be
> very
> > confused. We should probably consider moving the processing of options
> before
> > the imports, but until we do this, we should throw an error if the disable-
> > http-resolution option is encountered inside a module prolog.
>
> I'll implement something for this.
>
> > The error (and
> > the documentation) should say that this option is applicable only at the C++
> > api.
>
> Yes, you're right; I'll fix that too.