Code review comment for lp:~zorba-coders/zorba/bug-1188061

Revision history for this message
Luis Rodriguez Gonzalez (kuraru) wrote :

The documentation has several mentions to tests that are included but no
textual representations are made, Should I move some of the examples to the
code instead of sending the user to check the tests?
Aside from that the documentation seems to be pretty straight forward and
all the errors that I can think for each case seems to be covered.

Thanks,
Luis.

2013/6/14 Chris Hillery <email address hidden>

> Also, Luis: Have you done any investigation to ensure that the
> documentation is reasonable? In particular is the header comment clear,
> clean, and possibly have an example or two?
>
> And, can you verify that all reasonably-possible error conditions are
> documented? At least, are there any other XQuery error codes thrown by the
> module functions (or from the module C++ code, if any)?
> --
> https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
> You proposed lp:~zorba-coders/zorba/bug-1188061 for merging.
>

--

"The significant problems we face cannot be solved by the same level of
thinking that created them." -- Albert Einstein

« Back to merge proposal