Code review comment for lp:~zorba-coders/zorba/bug-1188061

Revision history for this message
Chris Hillery (ceejatec) wrote :

Looks pretty good so far! A couple questions for Matthias since he wrote the style guide:

1. Is this the correct way to use <p> for splitting doc paragraphs - wrapping them in <p>...</p> ? Or should there be single <p /> elements between paragraphs?

2. Is this the correct way to refer to error codes? I think there's supposed to be an actual module constant for each code, right? And then @error should list the constant?

review: Needs Information

« Back to merge proposal