Code review comment for lp:~zorba-coders/zorba/bug-1180220

Revision history for this message
Chris Hillery (ceejatec) wrote :

1. What's the difference between include/zorba/internal and include/zorba/util?

2. Was it necessary/a good idea to move cxx_util.h and error_util.h into the set of shipped headers?

3. Why was cxx_util.h moved to internal/ and error_util.h to util/ ?

4. Have you done any testing on Windows? There are several #ifdef WIN32 changes. If necessary I could request Juan or Luis to test it out (would prefer Rodolfo but he's busy with website stuff).

review: Needs Information

« Back to merge proposal