Merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

Proposed by Chris Hillery
Status: Merged
Approved by: Chris Hillery
Approved revision: 11327
Merged at revision: 11333
Proposed branch: lp:~zorba-coders/zorba/bug-1133260
Merge into: lp:zorba
Diff against target: 28 lines (+12/-5)
1 file modified
cmake_modules/ZorbaModule.cmake (+12/-5)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug-1133260
Reviewer Review Type Date Requested Status
Juan Zacarias Approve
Chris Hillery Approve
Review via email: mp+155878@code.launchpad.net

Commit message

Support global property ZORBA_PROJECT_UNAVAILABLE so non-core modules can inform Zorba build that they failed to find their dependencies.

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message):
  Validation queue job bug-1133260-2013-04-02T16-20-51.449Z is finished. The
  final status was:

  2 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1133260-2013-04-02T17-41-53.452Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake_modules/ZorbaModule.cmake'
2--- cmake_modules/ZorbaModule.cmake 2013-02-26 04:12:43 +0000
3+++ cmake_modules/ZorbaModule.cmake 2013-03-28 01:04:27 +0000
4@@ -719,13 +719,20 @@
5 # Now, do things that should be done at the end of *any* project, not
6 # just the top-level project.
7
8- # Generate project's projectConfig.cmake file.
9+ # Generate project's projectConfig.cmake file, unless the project told
10+ # us not to by setting the global property ZORBA_PROJECT_UNAVAILABLE to true.
11 # QQQ need to create an installable version of this too, once we know
12 # how installing a module package should work.
13- GET_PROPERTY (ZORBA_MODULE_LIBRARIES
14- GLOBAL PROPERTY "${PROJECT_NAME}_LIBRARIES")
15- CONFIGURE_FILE("${Zorba_EXTERNALMODULECONFIG_FILE}"
16- "${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.cmake" @ONLY)
17+ GET_PROPERTY (_unavailable GLOBAL PROPERTY ZORBA_PROJECT_UNAVAILABLE)
18+ IF (NOT _unavailable)
19+ GET_PROPERTY (ZORBA_MODULE_LIBRARIES
20+ GLOBAL PROPERTY "${PROJECT_NAME}_LIBRARIES")
21+ CONFIGURE_FILE("${Zorba_EXTERNALMODULECONFIG_FILE}"
22+ "${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.cmake" @ONLY)
23+ ELSE (NOT _unavailable)
24+ # Reset this variable so next project will still work
25+ SET_PROPERTY (GLOBAL PROPERTY ZORBA_PROJECT_UNAVAILABLE)
26+ ENDIF (NOT _unavailable)
27
28 ENDMACRO (DONE_DECLARING_ZORBA_URIS)
29

Subscribers

People subscribed via source and target branches