Code review comment for lp:~zorba-coders/zorba/bug-1026250

Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

> Thanks for the review.
> Can you explain me why
> SYNC_CODE(theCollection->theLatch.rlock();)
> and
> SYNC_CODE(theCollection->theLatch.unlock();)
> has been commented in this branch?
> They were already commented in the branch when I started working on it.
They were causing a deadlock when the collection being read from was modified. This is now fixed using collection versioning. The two lines can be removed.

« Back to merge proposal