Code review comment for lp:~ziminq/drizzle/filesystem-storage-engine

Revision history for this message
Monty Taylor (mordred) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/14/2010 03:31 PM, Brian Aker wrote:

>> 2. 'xread' vs 'internal::my_read,which one is preferred?
>
> Use posix based IO.

Yes. This is what I was going to say. We don't want to use my_read
because we don't want special random wrappers around posix in our code
that people can't read.

Just use read() directly.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw+LLMACgkQ2Jv7/VK1RgFLbQCdE1RU/6Gx/EVDIsv3MciLqJ7g
KUUAn2FtBO1JJEMrP1CuDDRmpmKGNxWj
=/JGZ
-----END PGP SIGNATURE-----

« Back to merge proposal