Code review comment for lp:~ziminq/drizzle/filesystem-storage-engine

Hi!

On Jul 14, 2010, at 7:12 AM, ziminq wrote:

> 1. store_lock is still used, as this storage engine is not critical about update/insert performance, and using table lock is easier to implement.

It is going away, and if we take an engine that uses it, it just forces us to rewrite that engine ourselves when it is fully gone.

> 2. 'xread' vs 'internal::my_read，which one is preferred?

Use posix based IO.

Cheers,
 -brian