Code review comment for lp:~zhuzhaoyuan/mysql-proxy/zhuzhaoyuan

Revision history for this message
Joshua Zhu (zhuzhaoyuan) wrote :

OK :)
But I think the patch below should be applied, otherwise the program would crash when the read_handshake() hook returning proxy.PROXY_SEND_RESULT
or proxy.PROXY_SEND_QUERY(see proxy_lua_read_handshake() for more details).

=== modified file 'plugins/proxy/proxy-plugin.c'
--- plugins/proxy/proxy-plugin.c 2008-12-04 20:07:39 +0000
+++ plugins/proxy/proxy-plugin.c 2009-02-06 13:19:41 +0000
@@ -469,7 +469,7 @@
  switch (proxy_lua_read_handshake(con)) {
  case PROXY_NO_DECISION:
   break;
- case PROXY_SEND_QUERY:
+ case PROXY_SEND_RESULT:
   /* the client overwrote and wants to send its own packet
    * it is already in the queue */

« Back to merge proposal