Code review comment for lp:~zeutschel/goobi-production/bug-1031240

Revision history for this message
Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount) wrote :

Works for me now. As a last request, please remove unneeded code from newpages/inc_AktuelleSchritte/schritt_box_Eigenschaften.jsp instead of commenting out (see first hunk of diff):

=== modified file 'newpages/inc_AktuelleSchritte/schritt_box_Eigenschaften.jsp'
--- newpages/inc_AktuelleSchritte/schritt_box_Eigenschaften.jsp 2011-12-22 13:29:56 +0000
+++ newpages/inc_AktuelleSchritte/schritt_box_Eigenschaften.jsp 2012-09-06 10:28:14 +0000
@@ -3,6 +3,8 @@
 <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
 <%@ taglib uri="http://jsftutorials.net/htmLib" prefix="htm"%>
 <%@ taglib uri="http://myfaces.apache.org/tomahawk" prefix="x"%>
+<%@ taglib uri="http://sourceforge.net/projects/jsf-comp/easysi" prefix="si"%>
+<%@ taglib uri="http://richfaces.org/rich" prefix="rich"%>

 <%--
   ~ This file is part of the Goobi Application - a Workflow tool for the support of
@@ -78,15 +80,15 @@
    </h:column>
   </x:dataTable>

- <%-- Neu-Schaltknopf --%>
+ <%-- Neu-Schaltknopf --%><%--
   <h:commandLink action="#{AktuelleSchritteForm.SchrittEigenschaftNeu}" id="new"
    value="#{msgs.eigenschaftHinzufuegen}"
    title="#{msgs.eigenschaftHinzufuegen}"
- rendered="#{AktuelleSchritteForm.modusBearbeiten!='schritteeigenschaft' && 0==1}">
+ rendered="#{AktuelleSchritteForm.modusBearbeiten!='schritteeigenschaft'}">
    <x:updateActionListener
     property="#{AktuelleSchritteForm.modusBearbeiten}"
     value="schritteeigenschaft" />
- </h:commandLink>
+ </h:commandLink> --%>

review: Needs Fixing

« Back to merge proposal