Code review comment for lp:~zematynnad/ubuntu-webcatalog/preflight_987822

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

While running the test suite I'm getting 3 failures that I already had notices in trunk, those are fixed in:

https://code.launchpad.net/~nataliabidart/ubuntu-webcatalog/law-and-order/+merge/108204

Would you please review and merge that branch in?

Besides that, I'm getting this output from the test run:

Creating test database for alias 'default'...
...................................................................F...F.......................F........................................................................................................................................Generated checkid_setup request to https://login.staging.ubuntu.com/+openid with assocication {HMAC-SHA1}{4fc7c2c1}{RSEj3w==}
................./home/nessita/canonical/webcatalog/review_preflight_987822/src/webcatalog/preflight.py:46:5: E303 too many blank lines (2)
.

Would you fix the pep8 issue? And perhaps check what is printing the "Generated checkid_setup request to..." message being printed?

Thanks!

review: Needs Fixing

« Back to merge proposal