Merge lp:~zematynnad/ubuntu-webcatalog/fix_tests into lp:ubuntu-webcatalog

Proposed by Danny Tamez
Status: Merged
Approved by: Anthony Lenton
Approved revision: 91
Merged at revision: 90
Proposed branch: lp:~zematynnad/ubuntu-webcatalog/fix_tests
Merge into: lp:ubuntu-webcatalog
Diff against target: 39 lines (+4/-3)
3 files modified
src/webcatalog/tests/test_pep8.py (+1/-0)
src/webcatalog/tests/test_views.py (+2/-2)
test_requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~zematynnad/ubuntu-webcatalog/fix_tests
Reviewer Review Type Date Requested Status
Anthony Lenton (community) Approve
Review via email: mp+99375@code.launchpad.net

Commit message

Fix tests on trunk

Description of the change

Overview
=========
This branch gets webcatlog trunk building again and fixes a few broken tests.

Details
========
test_requirements.txt was changed to require djang<1.4 so a 1.3x version would still be installed.

The links to http://ubuntu.com and https://canonical.com have changed to http://www.ubuntu.com and http://www.canonical.com respectively on the index page. It looks like the test was not yet updated.

Added a max_line_length attribute to the Options class as this was also causing the pep_8 test to fail.

To Test
=======
$fab bootstrap test

To post a comment you must log in.
Revision history for this message
Anthony Lenton (elachuni) wrote :

Thanks for cleaning this up Danny!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/webcatalog/tests/test_pep8.py'
--- src/webcatalog/tests/test_pep8.py 2012-01-06 18:10:30 +0000
+++ src/webcatalog/tests/test_pep8.py 2012-03-26 17:08:47 +0000
@@ -57,6 +57,7 @@
57 show_pep8 = False57 show_pep8 = False
58 select = []58 select = []
59 ignore = []59 ignore = []
60 max_line_length = 80
60 pep8.options = Options()61 pep8.options = Options()
61 pep8.message = self.message62 pep8.message = self.message
62 Options.physical_checks = pep8.find_checks('physical_line')63 Options.physical_checks = pep8.find_checks('physical_line')
6364
=== modified file 'src/webcatalog/tests/test_views.py'
--- src/webcatalog/tests/test_views.py 2012-03-20 22:23:31 +0000
+++ src/webcatalog/tests/test_views.py 2012-03-26 17:08:47 +0000
@@ -576,8 +576,8 @@
576 "https://bugs.launchpad.net/ubuntu-webcatalog/+filebug",576 "https://bugs.launchpad.net/ubuntu-webcatalog/+filebug",
577 "http://developer.ubuntu.com",577 "http://developer.ubuntu.com",
578 "https://launchpad.net/ubuntu-webcatalog",578 "https://launchpad.net/ubuntu-webcatalog",
579 "http://ubuntu.com",579 "http://www.ubuntu.com",
580 "https://canonical.com",580 "http://www.canonical.com",
581 ]581 ]
582 response = self.client.get(reverse('wc-index'))582 response = self.client.get(reverse('wc-index'))
583 for link in links:583 for link in links:
584584
=== modified file 'test_requirements.txt'
--- test_requirements.txt 2011-11-22 08:49:31 +0000
+++ test_requirements.txt 2012-03-26 17:08:47 +0000
@@ -3,7 +3,7 @@
3# Installed /.../virtualenv/lib/python2.6/site-packages/django_preflight-0.1-py2.6.egg3# Installed /.../virtualenv/lib/python2.6/site-packages/django_preflight-0.1-py2.6.egg
4# error: Could not find required distribution django4# error: Could not find required distribution django
5-f bzr+http://bazaar.launchpad.net/~elachuni/canonical-identity-provider/ssoclient#egg=ssoclient-1.05-f bzr+http://bazaar.launchpad.net/~elachuni/canonical-identity-provider/ssoclient#egg=ssoclient-1.0
6django6django<1.4
7coverage7coverage
8mock8mock
9piston-mini-client9piston-mini-client

Subscribers

People subscribed via source and target branches