Code review comment for lp:~zematynnad/ubuntu-webcatalog/banners_965560

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Nice and straight-forward - thanks Danny!

No need to change, but just if it's helpful information - you can actually grab things out of the response context for you test... in this case you could grab response.context['exhibits'] (or whatever it is in the context) and check the ordering directly, rather than having to search and compare indexes in the response html. That said, your current test is more end-to-end, as a template tag could always be used to reverse the order or whatever. Just food for thought:)

review: Approve

« Back to merge proposal